fix(hotswap): gate entry trampoline rewrites for gfx12.5#7593
Open
harsh-amd wants to merge 1 commit into
Open
Conversation
This was referenced Jun 22, 2026
harsh-amd
force-pushed
the
hotswap-entry-trampoline-gating
branch
from
2730218 to
8176f14
Compare
harsh-amd
force-pushed
the
hotswap-entry-trampoline-gating
branch
from
8176f14 to
ad38f93
Compare
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
harsh-amd
changed the title
harsh-amd
force-pushed
the
hotswap-entry-trampoline-gating
branch
from
b5f054a to
4b8391b
Compare
harsh-amd
requested review from
a team,
atgutier,
cfreeamd,
dayatsin-amd,
kentrussell and
shwetagkhatri
as code owners
github-actions
Bot
added
the
documentation
harsh-amd
force-pushed
the
hotswap-entry-trampoline-gating
branch
from
4b8391b to
51fa08c
Compare
harsh-amd
force-pushed
the
hotswap-entry-trampoline-gating
branch
from
51fa08c to
7fc15d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Layer 2 of the rocm-systems hotswap stack, paired with ROCm/llvm-project#3008.
GitHub targets this PR at
develop, so the default Files view includes prior stack layers. Use the layer-only diff above for review of this layer.Summary
hotswap_loader_policyand keep gfx12.5 matching plus gfx1250 stepping-feature construction private to that unit.AMD_COMGR_HOTSWAP_ENTRY_TRAMPOLINESas an opt-in for rocm-systems to attempt the gfx12.5 same-processor COMGR request path; COMGR owns what the flag enables internally.gfx125*targets andgfx12-5-genericwhile keeping non-gfx12.5 agents and source code objects unchanged.Testing
cmake -S projects/hotswap -B build-hotswap-reorder-layer2 -DCMAKE_BUILD_TYPE=RelWithDebInfo -Damd_comgr_DIR=/home/harsh/llvm-pr3000-refactor/build-comgr-displacement-shared/lib/cmake/amd_comgr -Dhsa-runtime64_DIR=/opt/rocm-7.2.0/lib/cmake/hsa-runtime64cmake --build build-hotswap-reorder-layer2 --target hsa-hotswap hotswap_test hotswap_tool_test hotswap_loader_test --parallel 32ctest --test-dir build-hotswap-reorder-layer2 --output-on-failurecmake --build build-hotswap-review --target hotswap_tool_test hotswap_loader_test --parallel 32ctest --test-dir build-hotswap-review -R 'hotswap_(tool|loader)_test' --output-on-failuregit diff --cached --check